JWTConnect-Python-OidcRP icon indicating copy to clipboard operation
JWTConnect-Python-OidcRP copied to clipboard

create_from_config_file was removed in tag 2.1.4

Open joe-jordan opened this issue 3 years ago • 6 comments

oidcrp.configure.create_from_config_file() was commented out in a recent commit, and published onto PyPI.

This broke production code, as we point our customers at pip as they install, and pull in new minor versions!

Could you please clarify if it was intentional, and in which case what is the replacement mechanism for loading config from files (I can't find a Release Notes for 2.1.4 which explains this)?

If you will fix this urgently and publish to PyPI, then we won't need to take any action, but if not we will need to patch our software to only accept versions <2.1.4 until it is resolved (by migration to a new implementation or by a fix.)

Thank you.

joe-jordan avatar Apr 11 '22 08:04 joe-jordan

I'll have a look at this after lunch.

You should consider moving from oidcrp to idpy-oidc. For several reasons we decided to merge oidcmsg, oidcrp and oidc-op into one package named idpy-oidc.

We will continue to fix bugs in oidcrp but all the major development work will happen in idpy-oidc.

rohe avatar Apr 11 '22 09:04 rohe

I should write a document describing what you need to do to move. I would be happy to discuss this with you.

rohe avatar Apr 11 '22 09:04 rohe

I will look into migrating in a future release, but we still need a solution for the released versions. Thank you for taking a look.

joe-jordan avatar Apr 11 '22 10:04 joe-jordan

The reason create_from_config_file was removed from OidcRP was that it's duplicated code to what's in oidcmsg.configure.create_from_config_file() . Part of a clean up.

rohe avatar Apr 11 '22 13:04 rohe

OK, thank you.

I will roll back our released versions to the last compatible version, and then await a migration guide. Will you update this issue later when that documentation is ready? or should I subscribe to something else?

joe-jordan avatar Apr 11 '22 13:04 joe-jordan

I can place a message here.

rohe avatar Apr 11 '22 13:04 rohe