oidc-client-js
oidc-client-js copied to clipboard
IdentityModel
Use ErrorResponse to get error_description.
error_description will be the default error message due to this change. Not sure how many users parse this error message and expect it to be 'error' and not 'error_description'.
Should I make a variant of ErrorResponse that will not change old behavior?
Can somebody review and merge this?
I would appreciate it too if this could be reviewed
me too! could @MayGo could you maybe merge https://github.com/IdentityModel/oidc-client-js/pull/1129 into yours? I would highly appreciate that.
@tobsch what do you mean exactly? Merge yours in this branch? This pull-request ain't moving also.
@MayGo no, i need #1129 to be merged and as you already have something on npm.org, i thought it makes sense to potentially push onre more thing in it so i do not need to fork it :-)
I understand everyone's frustration with not enough time being spent here... but each PR involve some amount of time and testing. Sorry, I don't have infinite time. I am working to get a little more help here in this repo, but given that it's all people's free time (non-paid), it's a challenge.
@brockallen totally makes sense - maybe you could open up for some contributors you trust? It smells like theres some optimization potential and the community could help?
added #1136: this includes github actions that would run with every checkin and pr. I understand that it's challenging and would like to to help lifting the overall quality
@tobsch I added your brach to temp package in npm.
@brockallen no problem. Totally understand.