IdeaTrackerPlus icon indicating copy to clipboard operation
IdeaTrackerPlus copied to clipboard

Task shouldn't be edited after set to done

Open manparvesh opened this issue 8 years ago • 8 comments

Description

Task shouldn't be edited after set to done

What are the steps to reproduce this issue?

  1. Set a task to done
  2. Edit it

What happens?

Edit dialog opens

What were you expecting to happen?

Shouldn't open

What versions of software are you using?

App version: 0.1

manparvesh avatar Jun 18 '17 08:06 manparvesh

Hi @manparvesh , I would like to work on this issue

ikakus avatar Sep 28 '17 10:09 ikakus

@ikakus sure, you are welcome to contribute!

manparvesh avatar Sep 28 '17 10:09 manparvesh

@manparvesh would it be better if we just hide "edit" button in this case?

ikakus avatar Sep 28 '17 11:09 ikakus

@ikakus both PRs looks similar, any specific reason for multiple PR?

naushad-madakiya avatar Oct 03 '17 19:10 naushad-madakiya

@naushad-madakiya The first one hides edit button from dialog, (just not adding this button). The second PR doesn't hide button but just disables action in it

ikakus avatar Oct 05 '17 05:10 ikakus

@ikakus seems both PRs has similar changes and same commits, can you point out where is separation for hide or disable the edit button?

naushad-madakiya avatar Oct 05 '17 06:10 naushad-madakiya

@naushad-madakiya I guess I messed this up. They should not be same :(

ikakus avatar Oct 07 '17 09:10 ikakus

@ikakus Don't worry, Have a look once. I guess there should be a small change. I guess we should disable the edit button once the task is done.

naushad-madakiya avatar Oct 07 '17 15:10 naushad-madakiya