Kuriimu icon indicating copy to clipboard operation
Kuriimu copied to clipboard

.XS save issue | Layton 5

Open swosho opened this issue 5 years ago • 2 comments

Issue: bug report Console: 3DS Format extension(s): .XS Type: text Game Name: Layton 5 / Professor Layton and the Miracle Mask (North American version)

First 8 bytes of the file(s): 58 53 43 52 0B 00 05 00 - XSCR

More details: I'm trying to edit subs in the cutscenes to match the spoken lines for the undubbed game. The problem is that after I finish editing the .xs file and save – the output file is always broken (see sample edited file). I've tried to nail down what causes it to be saved like that with no success, except it saves uncorrupted only if I just replace any number of characters in any number of words for some reason. Kuriimu 1.0.14.

Sample files: Original – https://drive.google.com/open?id=1u9_3YRDl4F71F56iUhkP0uHgIsKlG8lg Edited – https://drive.google.com/open?id=1dIFcIwd-GeI_nZy_UHuuWpcZpvYOEDgx

swosho avatar Jun 28 '19 13:06 swosho

Ah, sorry. Seems to be the same issue as: https://github.com/IcySon55/Kuriimu/issues/495

Edit: Okay, temporary solution from the referenced issue works wonderfully for me (one edited line per save though). I'm leaving here a prebuilt "fixed" plugin in case someone may come looking for it.

text_xs.zip

Edit 2: After all, the "fixed" plugin corrupts saved files too but not as severely: Original – 16_160020.xs Edited – 16_160020_edited_'fixed'.xs

Notice how the last line is a duplicate of the one before it. It happens after any kind of edit, yet it still sort of works with smaller files, apparently.

Edit 3: Tried editing subs for the FMVs and noticed that the "fixed" plugin consistently corrupts every bigger file. Sample files just in case: Original – 15_000001.xs Edited – 15_000001_edited.xs Edited "fixed" – 15_000001_edited_'fixed'.xs

Edit 4: As it turns out, seems like only all of the FMV cutscenes' subs + one of the 3D cutscenes' subs are affected. I've edited many other bigger .xs files with the "fixed" plugin and they're all good so far.

swosho avatar Jun 28 '19 13:06 swosho

In my experience, editing more than one line with the 'fixed' plugin causes a corrupt file. As does adding too much to a file or individual line (what 'too much' is varies from file to file, I believe because there must be some kind of byte limit). Saving, and then editing the same line and saving again can also corrupt the file.

collinxchu avatar Aug 22 '21 21:08 collinxchu