Feature/dns sorting 3507

[kroseneg]

This adds an option to the service grid to sort and group the hosts by the DNS hierarchy of the host name. See #3507 .

[cla-bot[bot]]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @kroseneg

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[kroseneg]

Hi

I've just signed the CLA. Please re-check my pull request, thank you.

Korbinian

On Mon, 2023-02-06 at 01:24 +0000, cla-bot[bot] wrote:

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA). Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA. After that, please reply here with a comment and we'll verify. Contributors that have not signed yet: @kroseneg

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.
• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

[decosilo]

@cla-bot check

[cla-bot[bot]]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @kroseneg

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[bobapple]

@cla-bot check

[nilmerg]

Hi,

I don't think we will merge this for the following reasons:

• It has a massive disadvantage because it only has access to a partial result returned by the database. Only a subset of so called pages will be ordered, though there may be more data on previous/next pages which would influence the shown result.
• Such a functionality won't be added here anymore. Icinga DB Web already supports sorting by multiple columns. The suggestion made here is already possible by using such a sort parameter: ?sort=host.vars.sub1,host.vars.sub0,host.vars.domain
  • A widget in the UI allowing to assemble such a rule more easily is already planned

Though, thanks for your contribution and effort anyway. It just would have been a good idea to ask whether such an implementation is worth taking on :wink: