icingaweb2
icingaweb2 copied to clipboard
Inconsistent comments in INI files
There is minor inconsistency with comment handling in INI file:
dir1 = "I have commentsPost( c1)" ; c1
dir2 = I have no comments ; c2
dir3 = I have commentsPre( c2) from previous line
BTW: for quoted value, garbage is silently ignored, possibly leading to hard-to-spot problems. Is it worth fixing?
dir = "this is dir value"but this part is ignored" ; and this is commentsPost
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).
Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.
After that, please reply here with a comment and we'll verify.
Contributors that have not signed yet: @ledvinap
-
If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.
-
If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.
Signed, but there may be something like 'significant change' filter. At least it is fun signing legalese for contributing 4 (hopefully useful) characters
@cla-bot check