icingaweb2 icon indicating copy to clipboard operation
icingaweb2 copied to clipboard

allow configuring the landing page

Open EmTeedee opened this issue 3 years ago • 5 comments

Not sure this was wontfix for a reason other than no interest. Renamed the branch in line with contributing guidelines.

Resolves #766

EmTeedee avatar Sep 30 '22 15:09 EmTeedee

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @EmTeedee

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

cla-bot[bot] avatar Sep 30 '22 15:09 cla-bot[bot]

CLA signed

EmTeedee avatar Sep 30 '22 15:09 EmTeedee

@cla-bot check

bobapple avatar Oct 04 '22 06:10 bobapple

If we're going to merge this, then only by making it configurable by envvar. This is only an edge-case configuration which most of our users don't need. And if it is relevant to someone, it doesn't change often. (or not at all)

So please fetch the option from the envvar ICINGAWEB_LANDING_PAGE and drop the UI integration.

nilmerg avatar Oct 04 '22 07:10 nilmerg

@nilmerg I've made the requested changes and added documentation.

EmTeedee avatar Oct 12 '22 16:10 EmTeedee