icingaweb2 icon indicating copy to clipboard operation
icingaweb2 copied to clipboard

Info about deactivated notifications disappeared

Open tgrymatt opened this issue 2 years ago • 1 comments

Describe the bug

If you disable the Notifications item in Icinga Web2 under Settings -> System -> State -> Icinga, then at least since version r2.13.4-1 you don't get any info about notifications being centrally disabled. In version r2.12.1-1 it definitely still worked. (See screenshots for details).

To Reproduce

  1. Open https://ICINGASERVER/health#!/monitoring/health/info in your webbrowser
  2. disable notifications

Expected behavior

There should be a clear information that the notification is disabled

Screenshots

New version without disabled notification: icinga-r2 13 4-1

Old version with disabled notification and the behaviour which I am missing: icinga-r2 12 1-1

Your Environment

  • Icinga Web 2 version and modules (System - About): 2.11.1
  • Web browser used: Chrome
  • Icinga 2 version used: r2.13.4-1
  • PHP version used (php --version): 7.3.31-1~deb10u1
  • Server operating system and version: Debian 10

tgrymatt avatar Jul 28 '22 14:07 tgrymatt

Yeah, that indicator got lost with #4651. The easiest and most-fitting solution now would probably be to extend Icinga\Module\Monitoring\ProvidedHook\Health to also provide statuses the Icinga\Module\Monitoring\Web\Navigation\Renderer\BackendAvailabilityNavigationItemRenderer has.

nilmerg avatar Jul 29 '22 06:07 nilmerg