icingaweb2-module-vspheredb icon indicating copy to clipboard operation
icingaweb2-module-vspheredb copied to clipboard

Fix NVME disk counter + "Best_Wins" logic fix

Open adn77 opened this issue 2 years ago • 4 comments

We noticed that disk performance counters did not get into InfluxDB when using NVMe disks. This PR fixes this issue.

adn77 avatar Nov 06 '23 10:11 adn77

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @adn77

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

cla-bot[bot] avatar Nov 06 '23 10:11 cla-bot[bot]

CLA has now been signed.

adn77 avatar Nov 06 '23 10:11 adn77

@cla-bot check

bobapple avatar Nov 06 '23 11:11 bobapple

Sorry for pushing this in a single PR, there was a logical error in the evaluation of best_wins (absolute or percentage). The best_wins setting was only taken into account if BOTH values were already below a not-normal state.

This should be an or condition.

adn77 avatar Mar 25 '24 20:03 adn77