icingaweb2-module-reporting icon indicating copy to clipboard operation
icingaweb2-module-reporting copied to clipboard

TimeframeForm: Use localDateTime instead of Flatpickr

Open jhoxhaa opened this issue 3 years ago • 1 comments

fix #128

jhoxhaa avatar Oct 12 '22 14:10 jhoxhaa

@jhoxhaa Please rebase and resolve merge conflicts.

Does the textual datetime description still work? For example -1 hour.

lippserd avatar Oct 26 '22 09:10 lippserd

With this, a textual input is only allowed for start and end simultaneously. A fixed datetime for end only doesn't make much sense, but for start. Consider a report that covers results since 01-01-2022 00:00:00. Of course, this is the same as the default timeframe Current Year, just expressed differently, but it shows that this example is not unreasonable. I'd opt for both expressions as a fixed date is more comprehensible as such a relative expression: first day of January this year midnight. (Especially easier to input, with the help of a widget) Though, wait for @lippserd's opinion before changing this.

Do you mean we should use fixed datetime only or that we should be able to use both expressions at the same time? 🤔

jhoxhaa avatar Nov 07 '22 09:11 jhoxhaa

Currently it's only fixed + fixed or relative + relative, what I'd like to have is: fixed + relative

nilmerg avatar Nov 07 '22 09:11 nilmerg

Once this is ready, please make sure that this issue doesn't occur anymore!

  • https://github.com/Icinga/icingaweb2-module-reporting/issues/172

yhabteab avatar Jan 12 '23 13:01 yhabteab