icingaweb2-module-director icon indicating copy to clipboard operation
icingaweb2-module-director copied to clipboard

Update documentation

Open martialblog opened this issue 3 years ago • 2 comments

Use shallow git clone to speed up download and reduce size on filesystem.

Before

git clone "${REPO_URL}" "${TARGET_DIR}" --branch v${MODULE_VERSION}
Cloning into '/usr/share/icingaweb2/modules/director'...
remote: Enumerating objects: 38601, done.

After

git clone --depth=1 "${REPO_URL}" "${TARGET_DIR}" --branch v${MODULE_VERSION}
Cloning into '/usr/share/icingaweb2/modules/director'...
remote: Enumerating objects: 1223, done.

Regards Markus

martialblog avatar Aug 18 '22 08:08 martialblog

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @martialblog

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

cla-bot[bot] avatar Aug 18 '22 08:08 cla-bot[bot]

@cla-bot check

bobapple avatar Aug 18 '22 09:08 bobapple

This currently downloads 3,09 MiB (vs 7,3 MiB) and needs 14M on disk (vs 23M). While I like the proposal, I prefer to skip it for now. It might confused those who're used to upgrade via git fetch && git checkout x.y.z afterwards

Thomas-Gelf avatar Sep 21 '22 06:09 Thomas-Gelf