Director doesn't save changes to timeperiods (when using browser)

[Stefomat]

Expected Behavior

When going to Director > Timeperiods > Timeperiods to adjust a time period, i press save, roll out the new configuration an it gets activated.

Current Behavior

When I go to Director > Timeperiods > Timeperiods to adjust a time period, the Director shows me a change in the activity log, but after rolling out the configuration, it is not active. Immediately after pressing "Save" of the changed period, the old period is displayed again.

Possible Solution

You can use the cli version of the director, e.g. icingacli director timeperiod set arbeitszeit --json '{"ranges": { "friday": "08:00-13:00", "monday": "08:00-16:00", "thursday": "08:00-16:00", "tuesday": "08:00-16:00", "wednesday": "08:00-16:00" }}'

Steps to Reproduce (for bugs)

Have a timeperiod configured or create a new one, e.g.

object TimePeriod "arbeitszeit" {
    import "legacy-timeperiod"
    display_name = "Normale Arbeitszeit"
    ranges = {
        "friday"	= "08:00-13:00"
        "monday"	= "08:00-16:00"
        "thursday"	= "08:00-16:00"
        "tuesday"	= "08:00-16:00"
        "wednesday"	= "08:00-16:00"
    }
}

Now go back to Director > Timeperiods > Timeperiods and try to modify one of the periods, e.g. tuesday from 16:00 to 17:00 Click save, view the activity log and try to activate the new configuration.

Your Environment

• Director version (System - About): 1.9.0
• Icinga Web 2 version and modules (System - About): 2.9.6
• Icinga 2 version (icinga2 --version): r2.13.2-1
• Operating System and version: Debian GNU/Linux 10
• Webserver, PHP versions: Apache2 2.4.38 | PHP 7.3

[Yoda-BZH]

I also have this behaviour when editing Scheduled downtimes. I suppose it's since v1.9.0 .

When editing a scheduled downtime, I have an entry in the activity log showing the change. However, each previously edited line has it's value reset.

Exemple: step 1: edit friday

step 2: edit monday

note that friday is back to it's previous value.

Your Environment

Director version (System - About): 1.9.1 Icinga Web 2 version and modules (System - About): 2.10.1 Icinga 2 version (icinga2 --version): r2.13.3-1 (2.13.3-1.bullseye) Operating System and version: Debian GNU/Linux 11 Webserver, PHP versions: Nginx 1.18.0-6.1 | PHP 7.4.28-1+deb11u1

[lucafwp]

Hi @Thomas-Gelf, since this has been removed from 1.10.0 milestone, will it be added to next version? Is there a way to fix this?

[Thomas-Gelf]

Hi @lucafwp,

guess this was just a matter of running out of time for the release. I'm working on v1.10.2 today and tomorrow, I'll try to fix this too.

Cheers, Thomas

[Thomas-Gelf]

Took me some time to track this down. Fixing it was easy - once I understood the problem :sweat_smile: