icingaweb2-module-director icon indicating copy to clipboard operation
icingaweb2-module-director copied to clipboard

Allow macros with parameters

Open v0tti opened this issue 3 years ago • 7 comments

This fixes #2432 by adding a matchRegex parameter. It should not break any existing use cases and just allows for more flexibility when using "Apply For" rules.

v0tti avatar Dec 06 '21 13:12 v0tti

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Alexander Votteler. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Dec 06 '21 13:12 cla-bot[bot]

I added the commit email address to my GitHub account, should be good now.

v0tti avatar Dec 06 '21 13:12 v0tti

@cla-bot check

nilmerg avatar Dec 07 '21 07:12 nilmerg

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @v0tti

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

cla-bot[bot] avatar Dec 07 '21 07:12 cla-bot[bot]

I have signed the CLA now. @cla-bot check

v0tti avatar Dec 07 '21 08:12 v0tti

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @v0tti

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

cla-bot[bot] avatar Dec 07 '21 08:12 cla-bot[bot]

@cla-bot check

bobapple avatar Dec 07 '21 08:12 bobapple