icingaweb2-module-director
                                
                                 icingaweb2-module-director copied to clipboard
                                
                                    icingaweb2-module-director copied to clipboard
                            
                            
                            
                        Allow macros to be a dict in service-apply-rules
Same as #1453, #2085 or #2446
In Service-Apply-Rules macros like $config.property$ should be evaluated, currently the only macro that gets evaluated is $config$
also fixes #2083.
This method doesn't need toConfigString modification.
This PR contains tests against this modification.
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau. This is most likely caused by a git client misconfiguration; please make sure to:
- check if your git client is configured with an email to sign commits git config --list | grep email
- If not, set it up using git config --global user.email [email protected]
- Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau. This is most likely caused by a git client misconfiguration; please make sure to:
- check if your git client is configured with an email to sign commits git config --list | grep email
- If not, set it up using git config --global user.email [email protected]
- Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails
Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).
Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.
After that, please reply here with a comment and we'll verify.
Contributors that have not signed yet: @Yoda-BZH
- 
If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case. 
- 
If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization. 
verified.
@cla-bot check
thank you.
Is there a way to run the CI against my PR ?
any news ?