icingaweb2-module-director icon indicating copy to clipboard operation
icingaweb2-module-director copied to clipboard

Allow macros to be a dict in service-apply-rules

Open Yoda-BZH opened this issue 4 years ago • 7 comments

Same as #1453, #2085 or #2446

In Service-Apply-Rules macros like $config.property$ should be evaluated, currently the only macro that gets evaluated is $config$

also fixes #2083.

This method doesn't need toConfigString modification.

This PR contains tests against this modification.

Yoda-BZH avatar Sep 08 '21 12:09 Yoda-BZH

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Sep 08 '21 12:09 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Tristan Charbonneau. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Sep 08 '21 12:09 cla-bot[bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @Yoda-BZH

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

cla-bot[bot] avatar Sep 08 '21 12:09 cla-bot[bot]

verified.

Yoda-BZH avatar Sep 08 '21 12:09 Yoda-BZH

@cla-bot check

bobapple avatar Sep 08 '21 14:09 bobapple

thank you.

Is there a way to run the CI against my PR ?

Yoda-BZH avatar Sep 09 '21 06:09 Yoda-BZH

any news ?

Yoda-BZH avatar Oct 13 '23 10:10 Yoda-BZH