icinga2 icon indicating copy to clipboard operation
icinga2 copied to clipboard

ITL - check_http - adds second http_post

Open TQQEU opened this issue 2 years ago • 8 comments

This PR adds second http_post for payloads containing a password. This is usefull in connection with Icingaweb2. This addition is important to us, as we need to test password-authentication this way, while in other cases the contents of "http_post" should be visible, e.g. if it contains SOAP-headers.

The variable-name http_post_pw utilises a default ("*pw*") described here

TQQEU avatar Oct 18 '23 05:10 TQQEU

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @TQQEU

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

cla-bot[bot] avatar Oct 18 '23 05:10 cla-bot[bot]

After that, please reply here with a comment and we'll verify.

done

TQQEU avatar Oct 18 '23 05:10 TQQEU

@cla-bot check

bobapple avatar Oct 18 '23 10:10 bobapple

What have you done and why exactly?

Al2Klimov avatar Dec 12 '23 14:12 Al2Klimov

What have you done and why exactly?

Hi, thanks for the question, I am still a bit new to this process here on github. I saw your comments yesterday and was looking arround on my github branch (the PR is made "from") for something I might need to confirm any process from my side. As far as I understood git and github here you pushed into my branch (TQQEU/Icinga2/). Also other things happened at the Icinga/Icinga/-Branch wich made me update my branch (TQQEU/Icinga2) by rebasing new commits from Icinga/Icinga2 to it. - Or that seems what the button I hit should have done to me.

TQQEU avatar Dec 12 '23 15:12 TQQEU

Please undo.

done. Thanks for the help!

TQQEU avatar Dec 12 '23 15:12 TQQEU