icinga2 icon indicating copy to clipboard operation
icinga2 copied to clipboard

Wrong executable name for check_systemd plugin

Open lyknode opened this issue 3 years ago • 3 comments

Hi,

In itl/plugins-contrib.d/systemd.conf, the command definition for check_systemd plugin looks for check_systemd.py.

However, in upstream README.rst, upstream icinga2 command definition and in Debian, the plugin is installed as check_systemd.

Would it be possible to update the plugin name in the docs and the command definition to match the command name as defined by upstream and installed in Debian?

Let me know if you want me to provide the corresponding PR.

Best,

lyknode avatar Oct 23 '22 09:10 lyknode

Please empower me to work on this issue.

krishnacx avatar Nov 01 '22 14:11 krishnacx

Please empower me to work on this issue.

You don't need any special permissions to create pull requests against this repo.

But let's first sort out if we want to change this. Has that project renamed the command in the meantime or does this discrepancy exist from the beginning? @yayayayaka As you added the command, do you know of any distributions that provide this check with the .py extension in the command name?

julianbrost avatar Nov 02 '22 07:11 julianbrost

This discrepancy exists since the beginning and we should fix that.

yayayayaka avatar Nov 02 '22 09:11 yayayayaka