Console::SetWindowsConsoleColor(): don't set black background

[Al2Klimov]

... but let it as-is.

Please see the commit messages.

[Al2Klimov]

Before

After

[Al2Klimov]

@cla-bot check

[yhabteab]

[Al2Klimov]

Ah, a Schrödinger's approval. 😁

[Al2Klimov]

In nodewizardcommand.cpp, there are a few instances that only do std::cout << ConsoleColorTag(Console_Bold), so that might still mess up some of the colors (from looking at the code, I think it might set the foreground color to black).

How? operator<<(std::ostream&,const ConsoleColorTag&) calls Console::SetWindowsConsoleColor() which I've changed here.

[julianbrost]

If the following if isn't executed (which it shouldn't if you don't set any Console_Foreground* flags but any other flags like Console_Bold):

https://github.com/Icinga/icinga2/blob/0303bcfd66aec666cee9b518ab4b833d63c94433/lib/base/console.cpp#L141-L142

So none of the FOREGROUND_* flags are added to attrs, which should result in black being the foreground color (given that case Console_ForegroundBlack does attrs |= 0).

[Al2Klimov]

I see... a badly described bad design decision.

[julianbrost]

I don't understand why you're closing this now. There's obviously something broken, by now, multiple persons spent time on this and it doesn't look like we are very far from something working.

[Al2Klimov]

To me the only solution looks very far.

[Al2Klimov]

Before

After

[Al2Klimov]

Change background color -> Blue:

So it doesn't work if you change it at runtime?