Delete acknowledgement with comment

[lazyfrosch]

I talked to a customer today who had problems deleting a bunch of acknowledgements with the old monitoring module. Since it would not make much sense to implement it there, I'll start the discussion here.

• You should be able to search for host/service with a certain acknowledgement or comment - filter by comment text
• When removing an acknowledgement comment, the acknowledgement should be removed (which deletes the comment as well)

[nilmerg]

Filtering by acknowledgement comment text is already possible.

I'm not sure about that removing an ack comment should also remove the ack. If at all, I'd expect Icinga to do that, not us. If Web does it, the API should do the same. This is not just a feature in Web to me, it's an integral part of how acknowledgements in Icinga work/are handled.

[lazyfrosch]

Nice, it is not with monitoring for host/service listings.

The second point way especially for comment listing or detail views, so maybe an extra button to reset ack there?

[nilmerg]

Then I would rather only provide a way to remove the ack, if it's an ack comment. Why should anyone want to differentiate here? (Between removing both or only the comment)

There's also the possibility to make an ack comment persistent, only in this case there's already a differentiation. The ack comment should be removable independently after the ack is cleared then.

So, in case of an ack comment the comment detail view:

• Allows to only remove the entire ack
• In case of an persistent comment, it can be removed after the ack has been cleared.

But then again, I'd question why removing a comment independently using the API is possible. The API should not allow to remove an ack comment then. (Possibly a breaking change.) Or automatically clear the ack as well. (My first suggestion.)

I mean, an acknowledgement without a comment is useless in my opinion. Why should that be preserved if the comment shouldn't?

[lazyfrosch]

I'm with you on that.

For icinga2 ack comment is just a field type for the Comment object, so there is just no other implementation here.

[nilmerg]

Then I'd move that to Icinga 2 to get the core devs on board? :grin:

[lazyfrosch]

Maybe just fix it on both ends? Multiple ack comments are possible even.

[nilmerg]

Multiple ack comments? If I try to ack a problem that has been acked already, the API gives me an error.

[lazyfrosch]

Maybe that was an Icinga 1 thing, I've seen it before :)

[lazyfrosch]

How can we fix this?

[ghost]

[ghost]

its all my acknowledgement how to fix it

[julianbrost]

@ereakimk I don't see how your screenshots relate to Icinga in any way. They look like they are a listing of licenses for third-party components in some app.