check_tcp ITL incompatibility between monitoring-plugins and nagios-plugins

[pprkut]

#7741 changed parameter names for check_tcp to update for a change in monitoring plugins. Unfortunately, this change in monitoring plugins is incompatible with the version of check_tcp shipped with nagios-plugins.

There's no monitoring-plugins rpm for RHEL/CentOS users and nagios-plugins is still recommended to be installed there per icinga documentation (https://icinga.com/docs/icinga2/latest/doc/02-installation/#rhelcentosfedora).

IMHO either the shipped ITL should work with both versions, or there should be a monitoring-plugins rpm for RHEL/CentOS users to switch to.

[pprkut]

Perhaps the path of least resistance is to rename the parameter in monitoring plugins from --sni to -N, and then revert the ITL change?

I see there was previous discussion going on but can't really follow the reasoning :-/

[mcktr]

Hi,

an incompatibility issue like this pops up over and over again, the two plugin packages monitoring-plugins and nagios-plugins are simply not compatible and honestly never will be.

@N-o-X Would it be possible to provide the monitoring-plugins package for RHEL/CentOS trough the Icinga repositories?

Best regards Michael

[Al2Klimov]

PING @N-o-X

[Seegras]

What's the status here? There are no nagios-plugins on Ubuntu, and monitoring-plugins check_tcp doesn't understand --sni.

[Al2Klimov]

@htriem I'd like to know especially:

Would it be possible to provide the monitoring-plugins package for RHEL/CentOS trough the Icinga repositories?

[lippserd]

@htriem I'd like to know especially:

Would it be possible to provide the monitoring-plugins package for RHEL/CentOS trough the Icinga repositories?

I can answer that: no.

[lippserd]

[...] monitoring-plugins check_tcp doesn't understand --sni.

It should actually. Maybe only a release is missing.

[Al2Klimov]

You're right. It should actually. https://github.com/monitoring-plugins/monitoring-plugins/commit/f53ea7afd8e124690871ebdb79a1432e4dd14488 is already included in some tags.

[Al2Klimov]

Perhaps the path of least resistance is to rename the parameter in monitoring plugins from --sni to -N, and then revert the ITL change?

I don’t think so...

I see there was previous discussion going on but can't really follow the reasoning :-/

... as the reasoning was doing it like check_http.

[Al2Klimov]

Would it be possible to provide the monitoring-plugins package for RHEL/CentOS trough the Icinga repositories?

Maybe our NETWAYS colleagues are so kind and package those in their repos.

CC @RincewindsHat

[RincewindsHat]

I am not totally opposed to that idea, but that requires time and effort. Not sure, if I can provide a time frame for that

[Al2Klimov]

Meanwhile all of you can checkout https://github.com/Linuxfabrik/monitoring-plugins which aren't OS-dependent. (https://twitter.com/al2klimov/status/1596206925330657282?cxt=HHwWhMDRxbrv7qYsAAAA) With recommendation from @gethash himself. (OSMC '22)

[RincewindsHat]

In the mean time: (Open)Suse builds RPMs, not sure how they are doing on RHEL

[Al2Klimov]

If they don't work OOTB, they may be rebuilt from source.

[Al2Klimov]

Added --sni to nagios-plugins as well.