icinga2 icon indicating copy to clipboard operation
icinga2 copied to clipboard

Feature/itl enable extra opts 7630

Open netphantm opened this issue 4 years ago • 9 comments

Adding --extra-opts to nagios plugins

fixes #7630

netphantm avatar May 14 '20 14:05 netphantm

I wanted to change also line 758, to escape the asterisk, since it changes the way it's rendered by vim w/ syntax highlighting from there onward (it makes all text italic), but changed it back to how it was initially..

netphantm avatar May 18 '20 11:05 netphantm

* [ ]  `git reset --soft HEAD~3`
* [ ]  `git commit --amend --no-edit`
* [ ]  `git push -f`

@Al2Klimov Looks like this has been addressed, do you mind updating your review?

julianbrost avatar Nov 24 '20 17:11 julianbrost

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bruno Lingner. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Aug 05 '21 05:08 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bruno Lingner. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Aug 16 '21 10:08 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bruno Lingner. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Aug 16 '21 10:08 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bruno Lingner. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Aug 16 '21 10:08 cla-bot[bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Bruno Lingner. This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

cla-bot[bot] avatar Aug 30 '21 09:08 cla-bot[bot]

@Al2Klimov I changed the email address, what do I have to do now to get the checks to be successful now?

netphantm avatar May 10 '22 07:05 netphantm

You have to change it in all commits here.

Al2Klimov avatar May 10 '22 08:05 Al2Klimov