icinga2 icon indicating copy to clipboard operation
icinga2 copied to clipboard

Published 20 hours ago • verified publisher icon Icinga

Remove deprecated features: compatlog, commandpipe

Open dnsmichi opened this issue 7 years ago • 19 comments

#6031 #6033 #6032

dnsmichi avatar May 15 '18 08:05 dnsmichi

If you remove this feature, could you please remove it properly (or fix it in 2.10). Version 2.10 breaks this feature but it's still working in 2.9.2. It is even in the documentation. If you enable the statusdata-feature in 2.10 the objects.cache-file isn't created anymore. If you run the command icinga2 object list --type=StatusDataWriter in 2.10 it crashes. In 2.9.2 it returns the proper output.

rippiedoos avatar Oct 17 '18 14:10 rippiedoos

The above was fixed, on removal it won't influence anything else.

dnsmichi avatar Mar 25 '19 10:03 dnsmichi

@lippserd Livestatus which is used by one of our key customers uses the compat logger for historical tables. Shall we care about this?

Al2Klimov avatar Feb 21 '20 16:02 Al2Klimov

CC @chrnie

Al2Klimov avatar Feb 21 '20 16:02 Al2Klimov

To be precise: It uses the logs produced by the compat logger.

Al2Klimov avatar Feb 21 '20 17:02 Al2Klimov

@lippserd Livestatus which is used by one of our key customers uses the compat logger for historical tables. Shall we care about this?

We cannot remove that for now, that's why this issue is subject for removal from 2.13.

dnsmichi avatar Feb 24 '20 08:02 dnsmichi

compat logger is an important feature for thruk's logfile cache. https://www.thruk.org/documentation/logfile-cache.html Finally, the entries are to end up in a database. If this feature is deleted, it would be nice if there was another possibility, apart from importing the IDO. Since not using the IDO was the initial reason to use livestatus.

chrnie avatar Mar 03 '20 16:03 chrnie

You're intentionally not using the IDO? Why?

And yes, there will be another possibility in v2.12 – IcingaDB.

Al2Klimov avatar Mar 03 '20 16:03 Al2Klimov

We should of course double check other tools using our features. If compatlog is used by thruk, we should not remove it. At least for now. We should get in touch with the thruk devs and work on an alternative before removing their access to reports.

statusdata and checkresultfilereader can be removed.

Did we already deprecate the command pipe?

lippserd avatar Mar 22 '20 21:03 lippserd

Yes, we did.

Al2Klimov avatar Mar 23 '20 14:03 Al2Klimov

Hello everybody,

I have a question concerning the planned removal of commandpipe. Will it be removed with the other deprecated features or might it be removed non the less even when the other removals are stalled?

I'm asking since we are now migrating from Nagios to Icinga2 and our IBM host administrators use NSCA for passive host checks. Although they will migrate to NRPE at some point at the moment there is no other possibility.

We don't want to get a situation where we would have to use the last working Icinga2 version with commandpipe thus not getting security features anymore. So: Is there a possible date when this removal will take place?

Best Regards, Johannes

johannesst avatar Jan 25 '22 15:01 johannesst

statusdata and checkresultfilereader can be removed.

Did we already deprecate the command pipe?

@lippserd Shall we throw those away in 2.14?

Al2Klimov avatar Oct 04 '22 16:10 Al2Klimov

v2.9

  • #6063
  • #6198

v2.11

  • #7078

I'd be nice and only throw out the v2.9 ones in v2.14.

Al2Klimov avatar Feb 23 '23 10:02 Al2Klimov

Note

We can't drop the command pipe until we have a comparable performant mechanism for feeding Icinga with bulk check results. (@Thomas-Gelf)

Al2Klimov avatar Feb 24 '23 16:02 Al2Klimov

Idea regarding command pipe (for one nice day): Remove not all at once, but throw out all not mission critical functionality of the command pipe. (But not in v2.14.)

Al2Klimov avatar Mar 01 '23 16:03 Al2Klimov