Feature/tags for elasticsearchwriter

[SebastianOpeni]

Offers to add additional tags to entries written by the ElasticSearchWriter.

As discussed with Eric at the icinga summit we are submitting this feature. Please revise the code and let us know if there is something we need to improve. otherwise we would be happy for timely merge.

fixes #6837

[cla-bot[bot]]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @SebastianOpeni

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[SebastianOpeni]

The CLA should be signed now.

[bobapple]

@cla-bot check

[SebastianOpeni]

Hi thanks for your review :) I am currently working on your remarks but might have some questions beforehand.

[SebastianOpeni]

Thanks for your answers in the review. I tried to implement everything as requested.

[yhabteab]

Apart from https://github.com/Icinga/icinga2/pull/10074#discussion_r1771206872, code wise it should be fine now, I haven't tested it with a actual ElasticSearch instance though, but till I get the time, some of my colleagues might want a look at this as well.

[SebastianOpeni]

I think I worked on all your requested changes, and you also marked them as resolved, but somehow they are still blocking the pipeline :thinking:

[yhabteab]

I think I worked on all your requested changes, and you also marked them as resolved, but somehow they are still blocking the pipeline 🤔

Hi, yes, thanks for that! Unfortunately, the GitHub actions were changed again with https://github.com/Icinga/icinga2/pull/10253 just after you rebased this against the master branch. You just need to rebase and force push again :)!

[SebastianOpeni]

Thanks for your fast reply :) I just pushed the rebased version. I hope the tests run smoothly :)

[SebastianOpeni]

The checks seem to be not the problem, but rather github does not register that we closed all your previously existing change requests. I think I have to "re-request" a review from you. :thinking:

[yhabteab]

The checks seem to be not the problem, but rather github does not register that we closed all your previously existing change requests. I think I have to "re-request" a review from you. 🤔

Hi, sorry for the delay! Unfortunately, there was again some changes made to the GitHub actions :-), and I wanted to rebase and clean up the commit histories for you but I'm not allowed to push it into this PR :(.

[SebastianOpeni]

Happy new year and nice to hear from you :smiley: Thank you for the effort, I invited you with write permissions I hope that will give you the necessary possibilities :)

[yhabteab]

I invited you with write permissions I hope that will give you the necessary possibilities :)

Thanks! But it would have been enough to just check the Allow edits by maintainers box.

[julianbrost]

@yhabteab Can you please state what you expect @lippserd to review here?

[yhabteab]

@yhabteab Can you please state what you expect @lippserd to review here?

Since @lippserd requested a change in https://github.com/Icinga/icinga2/pull/10074#discussion_r1771206872 not to send the tags fields to elastic search, so I wanted to know whether the changed (flattened) version of those matches his expectation.