Invoke-IcingaCheckUpdates: Output is confusing

[log1-c]

Hello :)

I updated the plugins to v1.10.1 recently and find the short message output of the plugin a bit confusing.

The output "Windows Updates: 6 OK" leads me to think that there are 6 updates available for this machine, and that that is "OK".

Though by now I figured out that the "6" refers to the 6 categories (summary, reboot, other, security, defender, rollups) I would still not suggest this output. And (imo) it gets worse/more confusing with threshold breaches

Suggestion: Don't display any numbers in the short message. Or add something like "category". OK: [OK] Windows Updates below thresholds CRITICAL/WARNING: [CRITICAL/WARNING] Windows Update Categories: 2 CRITICAL, 1 Warning, 5 OK (comma-separation)

Also I would suggest omitting the c unit in the text output.

Best log1c

[mantis]

Well also, if there are updates available in the pending restart state, it seems you get no warning:

unless you specify WarnOnReboot:

Now, I'd probably be inclined to say that the Warning state is wrong here - if an update is installed and the server has been restarted = OK, it's live and secure.

if an update is not installed, then that's BAD. if an update has been installed and is not active (e.g. server needs a reboot) - then that's BAD. I'd understand if this state was only a warning - but it shouldn't be a good(OK) state to be in.