icinga-packaging
icinga-packaging copied to clipboard
Published
20 hours ago •
Icinga
Icinga
icinga2: Review RPM Lint
We should review and fix at least the errors.
SPECS/icinga2.spec:27: E: hardcoded-library-path in %{_prefix}/lib/
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
SPECS/icinga2.spec:86: E: prereq-use permissions
The use of PreReq is deprecated. In the majority of cases, a plain Requires is
enough and the right thing to do. Sometimes Requires(pre), Requires(post),
Requires(preun) and/or Requires(postun) can also be used instead of PreReq.
SPECS/icinga2.spec:87: W: unversioned-explicit-provides monitoring_daemon
The specfile contains an unversioned Provides: token, which will match all
older, equal, and newer versions of the provided thing. This may cause update
problems and will make versioned dependencies, obsoletions and conflicts on
the provided thing useless -- make the Provides versioned if possible.
SPECS/icinga2.spec:213: W: unversioned-explicit-provides icinga-classicui-config
The specfile contains an unversioned Provides: token, which will match all
older, equal, and newer versions of the provided thing. This may cause update
problems and will make versioned dependencies, obsoletions and conflicts on
the provided thing useless -- make the Provides versioned if possible.
SPECS/icinga2.spec:319: E: hardcoded-library-path in %{_prefix}/lib/nagios/plugins"
A library path is hardcoded to one of the following paths: /lib, /usr/lib. It
should be replaced by something like /%{_lib} or %{_libdir}.
SPECS/icinga2.spec:343: W: mixed-use-of-spaces-and-tabs (spaces: line 2, tab: line 343)
The specfile mixes use of spaces and tabs for indentation, which is a cosmetic
annoyance. Use either spaces or tabs for indentation, not both.
You can fix them all, except from the hardcoded path which is required for SuSE not placing the plugins arch dependend.
Yeah, but we should distinquish the libdir between RPM and SUSE, since the Nagios Plugins are in /usr/lib64/nagios/plugins per default.
@lazyfrosch I am looking at fixing rpmlint and providing rpmlint config for issues we can accept, so I self-assign me this issue.
