ansible-collection-icinga icon indicating copy to clipboard operation
ansible-collection-icinga copied to clipboard
verified publisher icon Icinga

Feature folders inside files

Open fscaptain opened this issue 1 year ago • 6 comments

enables the use of a folder structure within files/ for more clarity and structure for custom configuration files.

fscaptain avatar Jun 23 '24 20:06 fscaptain

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @fscaptain

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

  • If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

cla-bot[bot] avatar Jun 23 '24 20:06 cla-bot[bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @fscaptain

* If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please [contact us](https://icinga.com/company/contact/) if you think this is the case.

* If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

CLA signed.

fscaptain avatar Jun 23 '24 20:06 fscaptain

CLA signed.

fscaptain avatar Jun 23 '24 20:06 fscaptain

@cla-bot check

bobapple avatar Jun 24 '24 07:06 bobapple

Hi, thanks for the PR. This seems to be a reasonable way to structure files in the files directory.

Can you add a changelog fragments as described in the following document? CONTRIBUTING.md

mkayontour avatar Jun 24 '24 07:06 mkayontour

Hi, thanks for the PR. This seems to be a reasonable way to structure files in the files directory.

Can you add a changelog fragments as described in the following document? CONTRIBUTING.md

Done.

fscaptain avatar Jun 24 '24 07:06 fscaptain

Hi, @Donien implemented the feature in a different PR. Can you check if this will solve your issue?

This allows you to structure your files within the "files" directory how you want. https://github.com/Icinga/ansible-collection-icinga/pull/313

mkayontour avatar Dec 04 '24 17:12 mkayontour

Hi,

the implementation from @Donien will solve this.

fscaptain avatar Dec 05 '24 07:12 fscaptain

Thanks, will be available with the next version. Closed

mkayontour avatar Dec 05 '24 08:12 mkayontour