ansible-collection-icinga icon indicating copy to clipboard operation
ansible-collection-icinga copied to clipboard

Misleading variable names in Icinga 2 API feature

Open tbauriedel opened this issue 1 year ago • 1 comments

As already discussed 'in real life' there are some variables with misleading names.

The variable ca_host inside the API feature for example is incorrect from an Icinga 2 technical point of view, as the "parent host" must be specified here in a distributed system with satellites. Naming to parent_host or similar would be more suitable.

Other examples are ca_host_port and icinga2_delegate_to.

As @mkayontour said, we need to make sure to have a transition phase for that. We could deprecate them and remove them in future versions.

tbauriedel avatar Feb 01 '24 07:02 tbauriedel

The way this feature works, ca_host is the correct name to go with, in my opinion, as the collection will indeed default to delegating the certificate creation to the ca_host.

mocdaniel avatar Feb 01 '24 10:02 mocdaniel