core_upgrader icon indicating copy to clipboard operation
core_upgrader copied to clipboard

[TASK] make it work with TYPO3 11.5

Open lukasniestroj opened this issue 2 years ago • 13 comments

Hi @IchHabRecht,

I have prepared most of the files to make it work with an installed TYPO3 11.5 and an old DB (7.6).

I left .travis.yml untouched since I am unfamiliar with that. The ext_emconf.php says

"version" and "dependencies" must not be touched!

so I didn't commit my change but it is important to set typo3 => '11.5.0-11.5.99'

In my opinion it should be a new major release 2.0.0 since it's not compatible with 10.4.

lukasniestroj avatar Feb 03 '22 12:02 lukasniestroj

@lukasniestroj Great work but: Call to undefined method TYPO3\CMS\Core\Resource\ResourceFactory::getInstance()

https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/10.3/Deprecation-90260-ResourceFactorygetInstancePseudo-factory.html

in TYPO3\CMS\v87\Install\Updates\ ImageCropUpdater and TYPO3\CMS\v87\Install\Updates\RowUpdater\ImageCropUpdater

can be easly fixed by replacing getInstance with GeneralUtility::makeInstance(ResourceFactory::class)

pulponair avatar Mar 03 '22 13:03 pulponair

@pulponair thanks. Fixed!

lukasniestroj avatar Mar 25 '22 12:03 lukasniestroj

Very nice thanks for your work @IchHabRecht and @lukasniestroj I'll test it and provide infos as well.

dkd-kaehm avatar May 18 '22 09:05 dkd-kaehm

This PR works for me, thanks. Would be nice to merge this PR and release the new version.

dkd-kaehm avatar Jun 07 '22 09:06 dkd-kaehm

Hi, Thank you for this pull request. Unfortunately it drops compatibility to TYPO3 10 which I want to support as well. If I have some time I can do some investigation.

IchHabRecht avatar Jun 07 '22 09:06 IchHabRecht

Unfortunately it drops compatibility to TYPO3 10 which I want to support as well.

@IchHabRecht But what about the unnecessary wizards for TYPO3 11, which will be then available for TYPO3 10 IMHO the version constraints are just fine. For TYPO3 10 the previous version must be used.

dkd-kaehm avatar Jun 07 '22 09:06 dkd-kaehm

@dkd-kaehm This is what needs to be investigated. I don't want to support multiple version of an extension if there is a way to unify those.

IchHabRecht avatar Jun 07 '22 10:06 IchHabRecht

I've just used this pull-request to update from V8.7 to V11. Thanks for this. The only issue i've had is that some V8.7 wizards did not work since the installation was build in V8.7 Removing V8.7 from Web/typo3conf/ext/core_upgrader/Configuration/Upgrades.php did the job.

Thanks for this, this will save me quite some time.

joey-bolts avatar Jan 31 '23 10:01 joey-bolts

I did an upgrade from 8.7 to 11.5 (PHP 7.4) with this fork and it worked fine

linawolf avatar Feb 09 '23 12:02 linawolf

We decided within an upgrade from 8.7 to 11.5 to use a PHP 8.1 compatible version of core_upgrader. We run all upgrade wizards while all TYPO3 v11.5 compatible extensions are installed. Some of this extensions offers required upgrade wizards. We decided so, cause new extensions are not required to be also PHP 7.4 compatible for upgrade prozess, when target PHP version is 8.1

jokumer avatar Feb 09 '23 12:02 jokumer

@jokumer Is there a PHP 8.1 compatible version of EXT:core_upgrader?

fnagel avatar Feb 09 '23 12:02 fnagel

@fnagel See forks or our last commit https://github.com/3pc-Berlin/core_upgrader/commit/62125d21e729e6b660036c855ae3408c9ef68b3d

jokumer avatar Feb 09 '23 12:02 jokumer

@lukasniestroj please see in #10

dkd-kaehm avatar Mar 24 '23 13:03 dkd-kaehm