content_defender icon indicating copy to clipboard operation
content_defender copied to clipboard

a simple quickfix for the workspace bug

Open vkemeter opened this issue 3 years ago • 4 comments

when saving a record in a workspace in a colpos with maxitems set, content_defender always returns false in the method isRecordAllowedByItemsCount(). in that case, i added a simple check for the t3ver_state column and return true, if it is not "published"

vkemeter avatar May 24 '22 05:05 vkemeter

Hi @vkemeter Just a quick look from my site, but doesn't this patch allows to insert unlimited new records in a workspace?! Furthermore the patch seems to be breaking in a default (non-workspace) space.

IchHabRecht avatar May 24 '22 09:05 IchHabRecht

hi nicole, no, you are not allowed to insert unlimited records in a workspace. i tried id. i guess, somewhere under the hood, there is a query where the records are fetched from the live stage? or some other stages? dont know exactly.

the other part, that it might break a non-workspace-installation could be, had that not in mind. this should be proofed if the column is available. i will check that in another typo3 installation without workspaces used.

vkemeter avatar May 24 '22 10:05 vkemeter

Hi @vkemeter

As the Travis CI tests turned red, something is broken definitely ;-)

IchHabRecht avatar May 24 '22 10:05 IchHabRecht

@IchHabRecht ok, that travis ci-testing color is an argument i cant deny ;) i'll try to test and fix that.

vkemeter avatar May 24 '22 10:05 vkemeter