content_defender icon indicating copy to clipboard operation
content_defender copied to clipboard

MaxItems and Workspaces

Open unherz opened this issue 3 years ago • 2 comments

Hi,

We are currently facing the same issue as #36 but in combination with the workspaces extension. The content is not savable after editing due to the maxItems exception.

AFAIK is the fix from #41 not applicable to this specific combination.

Could you please have a quick look into this issue?

We are using the following specs:

  • TYPO3 v. 10.4.18
  • workspaces v. 10.4.18
  • content_defender v. 3.1.4

unherz avatar Jul 23 '21 07:07 unherz

We having the same/similar issue, but for a translated record.

We have a backend layout with 3 rows and 1 column each. One column has the maxitems = 1 option set. The one element within the default language can be saved. The translated version cannot.

This is only happens if the translated version has not been published yet. After I publish everything I can edit the translated element and save every change within the workspace.

  • TYPO3 10.4.23
  • workspaces 10.4.23
  • content_defender 3.2.1

tpinne avatar Jan 27 '22 14:01 tpinne

hi, i have the same problem with the workspace and saving a content_element when a maxItem is set.

  • TYPO3 10.4.23
  • workspaces 10.4.23
  • content_defender 3.2.1

maybe we should proof, if the record is in a t3ver_state > 0 and return simply true in the isRecordAllowedByItemsCount method. that worked out for me.

if that is ok, i would add a PR and might patch it for myself.

greetings, volker.

vkemeter avatar May 23 '22 13:05 vkemeter

Hi!

I worked on workspaces compatibility the last couple of days. It would be awesome if anyone could try if the pull request https://github.com/IchHabRecht/content_defender/pull/116 solves the existing problem.

IchHabRecht avatar Jan 09 '23 14:01 IchHabRecht