Isaac Sukin
Isaac Sukin
Good. I'm not sure when I'll be able to get to this, so if anyone feels like providing a PR, that would move things along :smiley:
Okay, I wrote some code to do what was discussed above: https://gist.github.com/IceCreamYou/6b16d8350bc4125a08c76b499e0d4c59 I'm interested in some opinions: - Should a variation on this code be part of the main MainLoop.js...
Thanks for the feedback. > If you're using CJS/AMD/ES2015 modules then you'll get a new MainLoop when you import it. This is incorrect. Every module loader I know of caches...
> The example I was thinking of was embedding a MainLoop bundled app on another page with another bundle. As long as neither reference the global version (which would require...
Unfortunately not, but I'd be happy to merge a contribution!
The way this library is currently written, you wouldn't import it as a module. The typings would look something like this: ```ts declare module 'THREE' { export class Terrain {...
> Starting in the 2nd week of July, I could take over the library for a while and refactor it towards modules (I will try to keep it possible that...
Awesome :+1:
Cool! I just want to acknowledge that I have seen this and will take a look, but it may take me a bit considering the scope.
As an update, I'm about halfway through reviewing. Only a couple minor comments on the code as of yet. I'm also working through understanding a couple structural things. Good work...