plis
plis copied to clipboard
IcaliaLabs
AUR and local builds
What does this PR do?
- Updates the
README.mdwith info about how to install the package using AUR - Removes the necessity to do a symlink just to build the package locally
After the PR be accepted, it's possible to create a version on AUR that use the git version, plus the release version
You guys(@vovimayhem @thelastinuit) can you take a look at this, seems like a good contribution!
Thanks for it by the way @Ziul
@Ziul The best practice in the go universe says that relative path are not the go way. Every package should have a unique import path and be imported everywhere using that same import path. HOWEVER, it does work. @vovimayhem what say yo?
@thelastinuit That was something that really bothered me. The great motive for this PR was to include the plis-git on AUR, but I would need to build the package on local to the user. The way it was, I would make symlink from ~/ to some random path (probably /tmp), then go get to download plis, so then build it locally. It's madness the package to be self dependency. I asked two other AUR's maintainers what they think about it. Both reproved the way the package was doing.
To be honest, that was my first program on Go that a touch, and i got surprised that ../ did the trick, but if there is a better way to do it avoiding the symlink, I will be OK with it.
I think, take it with a grain of salt, there is a way with the latest updates but I'm not sure. Personally, I would accept the PR JUST to see it in AUR... it would be so badass. Let me get back to you @Ziul alright?
Finally had some time to prioritize thing a bit around, and reviewing this PR
...specially since #13 is still an [open and ongoing discussion](https://github.com/IcaliaLabs/plis/issues/13#issuecomment-3675509359.