Ian Manske

Results 80 comments of Ian Manske

Yeah, I could get behind making the signatures more consistent and spreadable using form `2.`. This could also help simplify the code and avoid bugs as #11212 highlights. One thing...

Thanks a lot for this! I will probably be using parent stacks to refactor a bunch of other code later. If I might make a few suggestions:

> Can you get rid of the `expect()`s? You may use the `report_error()` function, for example, to print an error about the error state but let's not kill Nushell. Good...

> I do think we should treat an unintentional clone as a fatal error here. The performance is just so bad if you have cloning and anything big in the...

> Sorry, I was out and about last week. All good, thanks for working on this! > Actually it's not clear to me if stack parents are workable in this...

Nice work! This looks good. > the test failure seems to be unrelated? Yep, some network tests started to become unreliable recently, these tests have been disabled. > Long term......

In version 0.92, output from external commands wrapped in parentheses should be streamed where possible (instead of collected).

@alesito85 @sholderbach The commented out lines are probably only relevant if nushell is being run from within another shell. For example, the last few lines handle job handling (`&` in...

Should be fixed with parent `Stack`s from #11654.

Since `net7.0` is out and ProjInfo is still wonky, I'll remark this as draft. If we end up coming back to ProjInfo just lmk, and I can start up again...