IWANABETHATGUY

Results 147 comments of IWANABETHATGUY

It seems that our `declare_rule` macro has already supported a lot of advanced markdown syntax, closed.

https://play.rome.tools/?lineWidth=80&indentStyle=tab&quoteStyle=double&indentWidth=2&sourceType=module&treeStyle=0&typescript=false&jsx=true#IAAgACAAIAAgACAAIAAgACAAIAA8AGgAMQAKACAAIAAgACAAIAAgACAAIAAgACAAIAAgAGMAbABhAHMAcwBOAGEAbQBlAD0AIgAuAC4ALgAiAAoAIAAgACAAIAAgACAAIAAgACAAIAA+AAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAUwBvAG0AZQAgAFQAZQB4AHQAPABiAHIAIAAvAD4ACgAgACAAIAAgACAAIAAgACAAIAAgACAAIAA8AHMAcABhAG4ACgAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgACAAYwBsAGEAcwBzAE4AYQBtAGUAPQAiAC4ALgAuACIACgAgACAAIAAgACAAIAAgACAAIAAgACAAIAA+AAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgAFQAZQB4AHQAIAAxAHsAJwAgACcAfQAKACAAIAAgACAAIAAgACAAIAAgACAAIAAgADwALwBzAHAAYQBuAD4ACgAgACAAIAAgACAAIAAgACAAIAAgACAAIABhAG4AZAB7ACcAIAAnAH0ACgAgACAAIAAgACAAIAAgACAAIAAgACAAIAA8AHMAcABhAG4ACgAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgACAAYwBsAGEAcwBzAE4AYQBtAGUAPQAiAC4ALgAuACIACgAgACAAIAAgACAAIAAgACAAIAAgACAAIAA+AAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAIAAgAFQAZQB4AHQAIAAyAAoAIAAgACAAIAAgACAAIAAgACAAIAAgACAAPAAvAHMAcABhAG4APgAKACAAIAAgACAAIAAgACAAIAAgACAAPAAvAGgAMQA+AA==, It seems prettier has the same behavior.

I am just curious why you prefer to use `{' '}` , because this should be transformed to the same HTML finally.

> > I am just curious why you prefer to use `{' '}` , because this should be transformed to the same HTML finally. > > Due to two reasons:...

A few suggestions: 1. Would you mind adding some valid cases in our generated markdown? https://github.com/rome/tools/pull/3078/files#diff-fdf4fb740794b3a765f8604dee5b3939df2fa9a5bf566e910c31b7db591373bcR26-R31

@ematipico Would you mind assigning me this task?

Why did I introduce the `logos` crate ? 1. Writing a lexer is boring and not easy, especially for a fast lexer. 2. See https://github.com/maciejhirsz/logos#logos - JSON lexer has no...

> What's the total size of these new dependencies and the impact on build size? > > How does the new lexer raise unicode and escape sequence errors? How flexible...

> What's the total size of these new dependencies and the impact on build size? > > How does the new lexer raise unicode and escape sequence errors? How flexible...

> make sense.