Isaiah Thomason

Results 74 comments of Isaiah Thomason

Hmmm. I'm more confident that this won't work now. In the TypeScript playground I tried: ```typescript type Blah = { pizza: string | number } & { [K: string]: number...

It would probably be good to have type tests to go with the change.

Interesting. So if the second type in the `OR` type chain is removed, then the error I mentioned earlier gets created. Seems inconsistent... hm....

Yeah. Due to the inconsistencies, I don't think I'm willing to approve this unless there are some robust tests to show nothing unexpected would happen.

I forgot to look at the tests. I'll look into this tomorrow.

I'm working on adding rate limiting to an existing Remix application, and I was thinking of adding my findings to the `remix-supertokens` repo in case it would be of interest....

To answer the authentication scenario, another alternative is to bump authentication to `hooks.server.ts`. That's where I do my auth, and I prefer it there so that no unauthenticated actions accidentally...

@JonathonRP It seems that the problem you're describing is related to a different issue. Is that correct? If so, do you still want to leave your comment here? Or migrate...

If ignoring the portal server-side isn't desirable, [some potential SSR approaches were mentioned](https://github.com/sveltejs/svelte/issues/1133#issuecomment-361026507). I'm not aware of Svelte's internals, but perhaps another solution is the following: While the HTML to...

Related (and potentially related) issues: #3088, #1133, #4237 (becomes obsolete if this feature is addressed), #4036 Outside `sveltejs/svelte`: romkor/svelte-portal#101