evalexpr icon indicating copy to clipboard operation
evalexpr copied to clipboard

Better node display

Open benwr opened this issue 2 years ago • 3 comments

Change the Display instance for Node. Previously it printed a simple pre-order traversal, which was sometimes ambiguous because e.g. for nested n-ary functions it wasn't clear which things were arguments.

Now, this should produce a visual that is (a) unique, and (b) can be parsed back into an equivalent Node.

benwr avatar Jun 03 '23 19:06 benwr

How would you feel about adding a dev dependency on quickcheck? I might want to randomly generate operator trees and check that they round-trip to the same trees.

benwr avatar Jun 04 '23 23:06 benwr

I am totally fine with new dev dependencies.

ISibboI avatar Jun 08 '23 12:06 ISibboI

It seems like propagating the precision does not work. We can either just not support floating point precision, or we fix that somehow.

ISibboI avatar Jun 27 '23 08:06 ISibboI