isa-api icon indicating copy to clipboard operation
isa-api copied to clipboard

comment_schema.json is different depending on the source

Open rabuono opened this issue 1 year ago • 4 comments

The comment_schema.json in the repo at: isatools/resources/schemas/isa_model_version_1_0_schemas/core/comment_schema.json

Is different from the one at the read the docs: https://isa-specs.readthedocs.io/en/latest/isajson.html#comment-schema-json

The "@id": { "type": "string", "format": "uri" }, property is missing in the GitHub version.

Was the @id for comments removed?

rabuono avatar Dec 09 '22 15:12 rabuono

I don't see any difference here.

vdkkia avatar Dec 09 '22 15:12 vdkkia

The "@id" property in "comments_schema.json" was removed by a commit of @proccaserra titled "addressing merge issues" on Feb 20, 2022: 9a463a3020ffb03de2a6951f26217bada87d1d26

image

Maybe this was an unintentional deletion?

@proccaserra Can you please comment or clarify on this?

patrick-koenig avatar Dec 20 '22 14:12 patrick-koenig

@rabuono @patrick-koenig this is an error (ie unintentional delete). thank you for reporting. fixing asap

proccaserra avatar Jan 03 '23 17:01 proccaserra

Thank you for checking it!

rabuono avatar Jan 05 '23 12:01 rabuono