ISAcreator icon indicating copy to clipboard operation
ISAcreator copied to clipboard

create distinct assay specific protocols when creating assays sharing process of similar protocol type

Open proccaserra opened this issue 11 years ago • 7 comments

Reported by Steffen:

To reproduce: add Metabolite Profiling assay using MS, it creates a metabolite identification protocol. Now, add Metabolite Profiling assay using NMR, it does not create a new metabolite identification protocol. In fact it should. While the protocol objective are the same, the actual methods are very different.

Note: the same is true for all those assay requiring 'material separation'

proccaserra avatar Oct 25 '12 13:10 proccaserra

Just change the config?

Eamonn Maguire Sent from my iPhone with tiny buttons

On 25 Oct 2012, at 07:51, Philippe [email protected] wrote:

Reported by Steffen:

To reproduce: add Metabolite Profiling assay using MS, it creates a metabolite identification protocol. Now, add Metabolite Profiling assay using NMR, it does not create a new metabolite identification protocol. In fact it should. While the protocol objective are the same, the actual methods are very different.

Note: the same is true for all those assay requiring 'material separation'

— Reply to this email directly or view it on GitHubhttps://github.com/ISA-tools/ISAcreator/issues/166.

eamonnmag avatar Oct 25 '12 14:10 eamonnmag

not sure, as the config allows to set the protocol type only, not the name but will double check, thx

proccaserra avatar Oct 25 '12 14:10 proccaserra

It's the same thing in this instance.

On 25 October 2012 08:18, Philippe [email protected] wrote:

not sure, as the config allows to set the protocol type only, not the name but will double check, thx

— Reply to this email directly or view it on GitHubhttps://github.com/ISA-tools/ISAcreator/issues/166#issuecomment-9779140.


Eamonn Maguire
Lead Software Engineer - ISA tools http://www.isa-tools.org/

University of Oxford Tel: +44(0)1865 610788 Oxford e-Research Center
7 Keble Road, Oxford skype: maguire1986

OX1 3QG, UK

eamonnmag avatar Oct 25 '12 14:10 eamonnmag

this is precisely the problem, the protocol name should have a 'counter' suffix to distinguish between protocols of the same type.

proccaserra avatar Oct 25 '12 15:10 proccaserra

You just have ms metabolite identification, nmr metabolite identification etc. I don't believe that creating counters will resolve the issue. It'll just make it look messy.

On 25 October 2012 09:01, Philippe [email protected] wrote:

this is precisely the problem, the protocol name should have a 'counter' suffix to distinguish between protocols of the same type.

— Reply to this email directly or view it on GitHubhttps://github.com/ISA-tools/ISAcreator/issues/166#issuecomment-9780858.


Eamonn Maguire
Lead Software Engineer - ISA tools http://www.isa-tools.org/

University of Oxford Tel: +44(0)1865 610788 Oxford e-Research Center
7 Keble Road, Oxford skype: maguire1986

OX1 3QG, UK

eamonnmag avatar Oct 25 '12 15:10 eamonnmag

right but this won't solve the pb either as i can have 2 ms assays using ms metabolite identification , (one assay for position mode and another one for negative mode).

of course i can create positive mode ms metabolite identification but it expands quickly.

proccaserra avatar Oct 25 '12 15:10 proccaserra

This is true. Hmmm. I don't believe that appending or pre-pending counters will help either. Since it's confusing and not obvious when it comes to using them later on. It won't be easy to identify what is what.

I'm not sure it will expand quickly though since the number of studies we have that have duplicated assays is none at present. MS is unique in this. Am I right? Therefore this solution will solve all our current problems. If something changes later on, we can revisit and make the changes.

On 25 October 2012 09:19, Philippe [email protected] wrote:

right but this won't solve the pb either as i can have 2 ms assays using ms metabolite identification , (one assay for position mode and another one for negative mode).

of course i can create positive mode ms metabolite identification but it expands quickly.

— Reply to this email directly or view it on GitHubhttps://github.com/ISA-tools/ISAcreator/issues/166#issuecomment-9781511.


Eamonn Maguire
Lead Software Engineer - ISA tools http://www.isa-tools.org/

University of Oxford Tel: +44(0)1865 610788 Oxford e-Research Center
7 Keble Road, Oxford skype: maguire1986

OX1 3QG, UK

eamonnmag avatar Oct 25 '12 15:10 eamonnmag