dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard
verified publisher icon IQSS

Move harvestingclient_id from the dataset to dvobject and use it directly for files

Open cmbz opened this issue 2 years ago • 9 comments

Description

  • Move the column harvestingclient_id from the dataset table in the database to the common dvobject.
  • This decision arrived at during a tech hour where it was decided not to redesign the concept of a harvested file, but instead make it easier to distinguish between harvested vs. 'real' files. See comment: https://github.com/IQSS/dataverse/issues/8629#issuecomment-1585099765

Any open or closed issues related to this feature request?

  • Closes spike issue: https://github.com/IQSS/dataverse/issues/8629

cmbz avatar Jun 30 '23 00:06 cmbz

Moved to @siacus backlog column to expedite lingering NIH GREI Year 1 work.

cmbz avatar Jun 30 '23 02:06 cmbz

2023/09/25: Added to 6.1 milestone as per conversation during prioritization meeting.

cmbz avatar Sep 25 '23 18:09 cmbz

2023/10/23: Sized at 10 during sizing meeting.

cmbz avatar Oct 23 '23 15:10 cmbz

The initial PR for this looks good and does what the issue states, that is move the column from one table to another (and modified the code which cares about where this info is for datasets appropriately).

However, while reviewing @landreev, @sekmiller and I agreed it would be better if the scope of this issue also encompassed making the relevant changes to the harvesting code to use the moved column for files, that being the motive for this new column. (note: we debated merging the PR and creating a new issue, but in this case it makes more sense to just keep the issue as is intact).

So I'm closing the PR and moving this issue to 6.2. With the new scope, it will also need to be resized.

scolapasta avatar Nov 30 '23 19:11 scolapasta

Also, note, this branch:

https://github.com/IQSS/dataverse/tree/9686-move-harvesting-client-id

should be the starting point to continue this work.

scolapasta avatar Nov 30 '23 19:11 scolapasta

2023/12/18

  • Sized at a 33 during the sizing meeting.

cmbz avatar Dec 18 '23 16:12 cmbz

Re-opening while discussions on how to proceed are ongoing

sekmiller avatar Jan 25 '24 20:01 sekmiller

2024/01/31

  • Adding waiting tag for now. Awaiting additional team input.

cmbz avatar Jan 31 '24 20:01 cmbz

2024/03/13 @landreev will discuss at a future Tech Hours and decide what to do about this specific issue (e.g., close/keep open)

cmbz avatar Mar 13 '24 17:03 cmbz