dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

IQSS/7349-3 file updates for schema.org

Open qqmyers opened this issue 2 years ago • 1 comments

What this PR does / why we need it: per the issue, we were sending the file mimetype in our schema.org metadata export and in-dataset-page metadata using a 'fileFormat' key which is non-standard - the schema.org spec specifies 'encodingFormat'. This PR makes the change to follow the spec.

Also per the issue - the code has not been sending the download url for restricted files. Since those URLs already handle access control and there's a separate 'dataverse.files.hide-schema-dot-org-download-urls' jvm option to not send any URLs if an admin so desires, (and because there are other (tbd) ways to indicate a file is not available without authorization), it doesn't seem helpful to hide just restricted/embargoed file urls by default. This PR also removes the if statement that did this.

Which issue(s) this PR closes:

Closes #7349

Special notes for your reviewer: all 4 PRs close this issue together.

Suggestions on how to test this: There is a test, but manually one can look at the page source or shcema.org export and verify that files have an 'encodingFormat' entry. Can also verify that the entries for restricted files also have a url now.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

qqmyers avatar Oct 19 '22 17:10 qqmyers

@sugatoray I tried and this was the output:

image

That's not a problem because I can always use JS, TS or something else... I was just curious about why the pyscript print function doesn't allow to generate HTML output. I hope that this Issue can be useful, if not I'll close it. Let me know, and thank you so much for your answer! Have a nice day.

coveralls avatar Oct 19 '22 17:10 coveralls

Prio meeting with Stefano.

  • Moved from External Commitments Backlog to ordered backlog

mreekie avatar Jan 10 '23 22:01 mreekie