dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

7000 mpconfig solr

Open poikilotherm opened this issue 2 years ago • 1 comments

THIS PR RELIES ON #8823 BEING MERGED FIRST, AS IT CONTAINS THOSE COMMITS, TOO!

(Technically you could also merge this one, but it might help to reduce brain load while reviewing when merging the base PR first)

What this PR does / why we need it: For unknown reasons, the Solr endpoint has been made configurable via a Database Setting only. This is very cumbersome for testing and container usage. Providing simple defaults via MPCONFIG takes lots of this load away. It also properly decouples creating the connection to Solr from the Database connection.

This PR is fully backward compatible with the old behaviour - anyone already having the database setting will let that setting take precedence!

This PR also very much enhances the configuration of the Solr connection, as it allows for the first time to choose transport protocol, core name and/or path, which makes it much more compatible with Solr installations that differ from our classic installations. (It does, however, not yet add support for SolrCloud).

Relates to #7000

Which issue(s) this PR closes: None.

Special notes for your reviewer: It is another good and simple start to see how the pieces laid out in #8823 are coming together.

TO SEE ONLY THE CHANGES IMPORTANT FOR THIS PR >CLICK HERE<

Suggestions on how to test this: Play around with the settings described in the added docsn and watch it work. Or take a look at the nice test examples, also using the new shiny @JvmSetting test extension!

Does this PR introduce a user interface change? If mockups are available, please link/include them here: Not really.

Is there a release notes update needed for this change?: Maybe? Dunno. Please leave comment.

Additional documentation: Included.

poikilotherm avatar Jun 30 '22 20:06 poikilotherm

Coverage Status

Coverage increased (+0.03%) to 20.015% when pulling 41c56ed59e89eaa0f498f131bef0d3014a91ca41 on poikilotherm:7000-mpconfig-solr into e6c033b79e9de112c2cf1949d1ac2c9846363038 on IQSS:develop.

coveralls avatar Jul 19 '22 18:07 coveralls

added to sprint Dec 15, 2022

mreekie avatar Dec 14 '22 21:12 mreekie

@poikilotherm more merge conflicts, as expected since other MPCONFIG PRs have been merged. Can you please resolved them?

pdurbin avatar Dec 20 '22 18:12 pdurbin

Ready to merge except for the merge conflicts.

kcondon avatar Dec 21 '22 21:12 kcondon

All set! :smile:

poikilotherm avatar Dec 21 '22 21:12 poikilotherm