IQSS
class field can be replaced by local variable
What this PR does / why we need it: class fields can be replaced by local variables which can save memory Which issue(s) this PR closes:
- Closes #8771
Special notes for your reviewer: no Suggestions on how to test this: code review Does this PR introduce a user interface change? If mockups are available, please link/include them here: no Is there a release notes update needed for this change?: reduce memory usage Additional documentation:
Coverage increased (+0.008%) to 19.718% when pulling 68be76766e4a23c1eaf8f9d625d515fb577603b8 on noobyu6:master into 21ac7e1e7d9123bcfc071e2c00989b4347a7b5c0 on IQSS:master.
Hi @noobyu6 , for this next sprint we are catching up on Community PRs. Would you mind updating/ refreshing thiis PR from develop? Thanks!
As discussed at standup, we're comfortable with the same person doing review and QA. I'm merging this. Again, it's a trivial change and the SWORD API tests pass.
@noobyu6 I'm very sorry but I merged this pull request without noticing that it was targeting the "master" branch rather than the "develop" branch. Can you please create a new pull request that targets the "develop" branch? Thanks.
I see the same situation exists in the master branch, so merging into the master branch is also ok
@noobyu6 no. I reverted the master branch (see #8967). It comes down to our process. All PRs are merged into develop. Then at release time we merge develop into master. So please make a new PR against develop if you want this change. Sorry for the inconvenience.