dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

Upgrade from Payara 5 to 6

Open pdurbin opened this issue 2 years ago • 2 comments

What this PR does / why we need it:

Payara 5 is going EOL.

Which issue(s) this PR closes:

  • Closes #8305

Special notes for your reviewer:

  • Do not move this to QA until Payara 6 Alpha 3 is out and we can test with it.
  • Do not move this to QA until Payara 6 Final is out and we can test with it.
  • Do not move this to QA until we've made a final decision to go with the Rewrite/PrettyFaces library I built on my Mac and put in local_lib. Check https://github.com/ocpsoft/rewrite/issues/304 for progress toward a compatible release from upstream.
  • Instead of d86e220 should we preserve backward compatibility of the SWORD API by inserting attachment; for the user if it isn't supplied?
  • The Perl installer has not been updated. Honestly, I'm ok with deleting it (and references to it, of course, if any).
  • The release note snippet needs work. Upgrades have not been tested.

Suggestions on how to test this:

  • Make sure API tests pass.
  • A test server is coming, similar to the one for Payara 5: https://groups.google.com/g/dataverse-dev/c/5hfiXl4Hpd8/m/awzoSpupAQAJ
  • Test everything. Test, test, test, just like the last major version change.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No

Is there a release notes update needed for this change?:

Yes, a stub is included.

Additional documentation:

None but references in the guides to Payara 5 have been switched to Payara 6.

pdurbin avatar Jun 03 '22 19:06 pdurbin

It looks like there's been some movement on the Payara side, a good time for this to go back into dev. (Also, note that it's showing a few conflicts now)

Correct - a mvn package results in controlledvocabulary and other language bundle errors, but there is concern that a merge with develop could take several hours. I have the full Maven output if anyone is interested, but I'm less inclined to waste anyone's time with it until the branch is current with develop.

donsizemore avatar Jul 20 '22 14:07 donsizemore

Coverage Status

Coverage decreased (-0.007%) to 19.758% when pulling d1a19f358d6639dd5c05a51579dffa6ceef7a3d6 on 8305-payara6 into 567e5065756ce60c6e08e32438f39304d55b1568 on develop.

coveralls avatar Jul 20 '22 15:07 coveralls

@pdurbin what do we do with this PR? It's based on Jakarta EE 9.1, but we need EE 10. I did that in https://github.com/IQSS/dataverse/tree/8305-payara6-ee10. Should we open a new PR?

poikilotherm avatar Nov 02 '22 08:11 poikilotherm

@poikilotherm yes, a new PR is better. I'm closing this one. Thanks!

pdurbin avatar Nov 02 '22 13:11 pdurbin

This is the new PR (thanks, @poikilotherm!):

  • #9116

I deleted the old branch to reduce confusion. 😄

pdurbin avatar Jan 26 '23 13:01 pdurbin