dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

For some roles, objects are not populated in alert message

Open kaitlinnewson opened this issue 7 years ago • 6 comments

For some roles (Dataset creator, Dataverse + Dataset creator, Dataverse creator), the objects that the role will affect are not populated. This also applies to any custom role created that is given the same permissions as the roles above.

Tested in both 4.9.4 and 4.8.6.

screen shot 2018-11-28 at 3 15 32 pm screen shot 2018-11-28 at 3 16 37 pm

kaitlinnewson avatar Nov 28 '18 20:11 kaitlinnewson

@kaitlinnewson I'm not sure if I completely understand what you mean but clearly the red text in both screenshots is nonsensical (File Downloader will also have File Downloader?!?) so we should at least fix that. Thanks for the bug report. Please feel free to write more to help us better understand.

pdurbin avatar Nov 28 '18 20:11 pdurbin

I don't read the first is nonsensical, though could possibly be more clear. It is stating that assigning the FileDownloader role at the Dataset level, means that user will also have the File Downloader role on all the files. (i.e they would be able to download any file in that Dataset).

The second one seems to be missing "Datasets and Files" after "applied to all"?

scolapasta avatar Nov 28 '18 20:11 scolapasta

Ah, maybe we could add "at the Dataverse level" to improve clarity. Something like "Assigning the File Downloader role at the Dataverse level means the user(s) will also have the File Downloader role applied to all Files within this Dataverse. I don't know. Whatever sounds best. Maybe it's easier to express in French. 😄

Staring at dataverse.permissions.usersOrGroups.assignDialog.role.warning=Assigning the {0} role means the user(s) will also have the {0} role applied to all {1} within this {2}. helps me understand that {1} is not being populated in the second screenshot. Thanks.

pdurbin avatar Nov 28 '18 21:11 pdurbin

Staring at dataverse.permissions.usersOrGroups.assignDialog.role.warning=Assigning the {0} role means the user(s) will also have the {0} role applied to all {1} within this {2}. helps me understand that {1} is not being populated in the second screenshot. Thanks.

In retrospect I probably should have included that for clarity!

kaitlinnewson avatar Nov 29 '18 16:11 kaitlinnewson

Related to Permissions - Improve Descriptions of Roles #4389.

mheppler avatar Nov 29 '18 17:11 mheppler

@kaitlinnewson heh. No worries. Sorry for the noise. My brain was having trouble parsing the sentence in the Dataverse UI.

pdurbin avatar Nov 29 '18 17:11 pdurbin