dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard
verified publisher icon IQSS

add "review" dataset type and related metadata blocks

Open pdurbin opened this issue 4 months ago • 14 comments

What this PR does / why we need it:

  • Adds "review" as dataset type and publishes resourceTypeGeneral=Other to DataCite for it.
  • Adds custom metadata blocks related to reviews

Which issue(s) this PR closes:

  • Closes #11747

Special notes for your reviewer:

  • This is a decent entry point for the docs: https://dataverse-guide--11753.org.readthedocs.build/en/11753/api/native-api.html#add-dataset-type
  • I'm aware that Properties Check / Metadata Blocks Properties (pull_request) is failing. @jggautier can you please provide the properties files?
  • I haven't acted on the conversation with @qqmyers about data citation: https://github.com/IQSS/dataverse/pull/11753#pullrequestreview-3140829669
  • I'm aware that clicking a facet under "Dataset Type" in the SPA doesn't work. This is being tracked in a separate issue:
    • #11758

Suggestions on how to test this:

  • Add "review" as a dataset type
  • Test DataCite changes
    • Create a dataset of type "review" and confirm that DataCite shows it at "Other"
  • Test data citation changes
    • ... I'm not sure how to test this. See comment above.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No, but here's a screenshot from https://dev1.dataverse.org/spa/collections showing the facet:

Screenshot 2025-08-27 at 4 51 27 PM

Is there a release notes update needed for this change?:

Included

pdurbin avatar Aug 19 '25 19:08 pdurbin

Coverage Status

coverage: 23.737% (-0.003%) from 23.74% when pulling 99fcede6aa3a31d96e3a3933b8b2c0ffff227d88 on 11747-review-dataset-type into 40bf831835752e69ba34438710f1cbf3877047fa on develop.

coveralls avatar Aug 19 '25 19:08 coveralls

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Aug 19 '25 20:08 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Aug 26 '25 15:08 github-actions[bot]

Next Tuesday I'll add to this PR . properties files for the two metadata blocks

jggautier avatar Aug 27 '25 21:08 jggautier

I put the two properties files for the metadata blocks into this branch's src/main/java/propertyFiles folder

jggautier avatar Sep 02 '25 13:09 jggautier

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Sep 02 '25 14:09 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Sep 17 '25 18:09 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Sep 26 '25 14:09 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Sep 30 '25 20:09 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Oct 08 '25 16:10 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Oct 08 '25 17:10 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Oct 08 '25 20:10 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Oct 23 '25 17:10 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:11747-review-dataset-type

ghcr.io/gdcc/configbaker:11747-review-dataset-type

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Oct 23 '25 21:10 github-actions[bot]