Ordering subfields while displaying dataset version differences

[luddaniel]

What this PR does / why we need it:

Ordering subfields while displaying dataset version differences

Which issue(s) this PR closes:

• Closes #10968

Special notes for your reviewer:

This code looks NullPointerException safe so I didn't overprotect it.

Suggestions on how to test this:

Create multiple versions by modifying the subfields each time and checking the operation with the comparison pop-up.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Before:

After:

Is there a release notes update needed for this change?:

yes

[coveralls]

coverage: 20.878% (-0.003%) from 20.881% when pulling b3147a083d140b6a9a2feea21aa043621f692fcc on Recherche-Data-Gouv:10968-order-subfields-version-difference into 03538f0ddba10bc77517dfe78ef70bbc3f978984 on IQSS:develop.

[pdurbin]

@luddaniel thanks for the PR! Any idea why we are seeing has this error?

org.opentest4j.AssertionFailedError: expected: <8> but was: <7>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:150)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:145)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:531)
	at edu.harvard.iq.dataverse.api.HarvestingClientsIT.harvestingClientRun(HarvestingClientsIT.java:301)

[landreev]

It's very unlikely, for anything in this PR to cause that test to fail. It is known to be a little flaky - let me take a quick look. I also kicked off Jenkins to run one more time.

[landreev]

(seeing how Jenkins tests did succeed once earlier today, on the same branch minus the release note, I am not too worried about it)

[landreev]

It has just passed again (build #3). Somebody, merge it please before it breaks again.

[pdurbin]

Ha, well, I did put it in our new "ready for triage" column which we now look at as a team on Tuesdays, I believe.

It looks like there's the potential for merge conflicts with this PR:

• #10945

[ofahimIQSS]

@luddaniel After pushing the fix to Internal and testing it, I noticed that the issue is still observed. See screenshots along with test steps below:

Test Steps:

1. Go to https://dataverse-internal.iq.harvard.edu/
2. Create new dataset and populate required fields.
3. Populate Keyword section with data below (see screenshot)
4. Save and publish data set
5. Edit Metadata for dataset and add two more terms (see screenshot below)
6. Save the dataset then go to versions tab
7. For the Dataset Version Draft, click on view details under summary

[luddaniel]

Hi @ofahimIQSS Maybe my eyes trick me but it looks to work as expected :)

[ofahimIQSS]

Merging PR - Testing Passed. Testing of 10969.docx

@luddaniel Thank you!