dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

bump to Postgres 17, Flyway 10.19, allows earlier versions of PostgreSQL

Open donsizemore opened this issue 1 year ago • 3 comments

What this PR does / why we need it:

Bumps Postgres to version 17 and Flyway to version 10.19. The Flyway version change is significant, as version 10 removes the requirement that users purchase licenses to use older/non-supported versions of Postgres.

Which issue(s) this PR closes:

  • Closes #10889

Special notes for your reviewer:

None

Suggestions on how to test this:

Standard test suite run.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

No.

Is there a release notes update needed for this change?:

Might be nice to note the removal of the Flyway restriction? Don't want to encourage older versions, tho.

Additional documentation:

None

donsizemore avatar Oct 08 '24 14:10 donsizemore

Coverage Status

coverage: 21.224%. remained the same when pulling d1f9970ed303c3af0ecd374ed333578c2ccc21b6 on uncch-rdmc:10889_bump_PG17_FlyWay10 into 6a00ce51cc5072695411c8100238a3165506ba70 on IQSS:develop.

coveralls avatar Oct 08 '24 14:10 coveralls

@donsizemore IIRC you needed to add a Postgres Package for Flyway with 10.x. Is this no longer true?

poikilotherm avatar Oct 09 '24 06:10 poikilotherm

@poikilotherm I thought that was this? https://github.com/IQSS/dataverse/pull/10912/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R182 End-to-end tests passed on develop.

donsizemore avatar Oct 09 '24 11:10 donsizemore

As a sanity check, I went to https://github.com/gdcc/dataverse-ansible/blob/51587e7231ffca474ad2b751f2e4508f7f9f8c7d/tests/group_vars/jenkins.yml#L277 which is the latest, to see that we're still going to test with Postgres 13. That's great because we still say "PostgreSQL 13 is recommended because it’s the version we test against" as of this PR at https://dataverse-guide--10912.org.readthedocs.build/en/10912/installation/prerequisites.html#postgresql

The docs seem fine and accurate as-is.

This PR will have the effect of upgrading the Docker images to Postgres 17. I'll go add a suggestion to the release notes about that. It will mean the Docker images will be out of step with the classic installation. This is probably ok as the Docker image is already at 16 (psql (16.3 (Debian 16.3-1.pgdg120+1)) as of this writing) while the classic instructions for production suggest using 13 and for dev suggest using 13 as well.

pdurbin avatar Oct 31 '24 19:10 pdurbin

Performed regression testing on Internal. No issues uncovered - Merging PR.

https://github.com/user-attachments/assets/b690ce4f-2a64-48c9-992e-85cec36f20e6

ofahimIQSS avatar Nov 06 '24 19:11 ofahimIQSS

I'm pretty sure developers need to blow away their database

I sent a note about this: https://groups.google.com/g/dataverse-dev/c/ffoNj5UXyzU/m/nE5oGY_sAQAJ

pdurbin avatar Nov 07 '24 20:11 pdurbin