dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

Solr 9.6.1 and other lib updates from QDR

Open qqmyers opened this issue 1 year ago • 2 comments

What this PR does / why we need it: QDR has updated to Solr 9.6.1 and uses other libraries that are more recent than the community version. This PR shows what QDR has changed.

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: Would need standard solr install instructions

Additional documentation:

qqmyers avatar Jul 21 '24 17:07 qqmyers

Coverage Status

coverage: 22.721% (-0.005%) from 22.726% when pulling c24b22445bbed157cfc1728798097aec03cb327c on QualitativeDataRepository:QDR-solr_and_libs_updates into b0d136cc8f7c17a4db667984072f854cdf7b2adc on IQSS:develop.

coveralls avatar Sep 03 '24 18:09 coveralls

Thankfully many few places to change now that the files go in /conf/solr! As of now, the only 9.4.1 references are in the old release notes.

qqmyers avatar Oct 10 '24 21:10 qqmyers

Solr is such a moving target. 9.7 is out. Do we care? Stick with 9.6.1? https://solr.apache.org/downloads.html

p.s. There are merge conflicts.

pdurbin avatar Nov 07 '24 20:11 pdurbin

Again, Solr is such a moving target. 9.7 is out. Do we care? Stick with 9.6.1? https://solr.apache.org/downloads.html

p.s. There are merge conflicts.

pdurbin avatar Dec 04 '24 20:12 pdurbin

FYI - @donsizemore ran this with solr 9.7.0 to show the tests pass - in https://jenkins.dataverse.org/job/IQSS-Dataverse-Solr_9.7.0/4/console. Since the solrconfig.xml appears to not be compatible with solr 9.4.1, it looks like we need to update the normal build once this is merged to get the IT tests to work on develop.

qqmyers avatar Dec 18 '24 15:12 qqmyers

I'm guessing the test fails are because we need to build against solr 9.8.0. The solrconfig.xml used here works fine for me to spin up 9.8.0 on a QDR test machine.

qqmyers avatar Feb 07 '25 14:02 qqmyers

the Jenkins job failed (no permission to update the build status in QDR's GitHub repo) but all tests passed: https://jenkins.dataverse.org/job/IQSS-Dataverse-Solr_9.8.0/66/testReport/

donsizemore avatar Feb 07 '25 21:02 donsizemore

This is still failing a bunch of tests as of the latest merge from develop

sekmiller avatar Feb 26 '25 14:02 sekmiller

Changes made. The tests fail because Jenkins is building against solr <9.8.0 . Don made a special run to show the tests pass against the right solr version - https://github.com/IQSS/dataverse/pull/10713#issuecomment-2644152027

qqmyers avatar Feb 26 '25 14:02 qqmyers

continuous-integration/jenkins/pr-merge is failing - please advise. Thanks!

ofahimIQSS avatar Feb 26 '25 21:02 ofahimIQSS

@ofahimIQSS, as Jim notes above the tests are failing because Jenkins is on the prior version of Solr. When Don updated the version for a special run they passed.

sekmiller avatar Feb 26 '25 21:02 sekmiller

regression testing passed - merging PR

ofahimIQSS avatar Feb 26 '25 21:02 ofahimIQSS