dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard
verified publisher icon IQSS

Guestbook email field does not check email validity

Open DS-INRAE opened this issue 1 year ago • 1 comments

What steps does it take to reproduce the issue? Set a guestbook on a dataset, attempt downloading files from the dataset enter a value in the email field of the guestbook which isn't a correct email voilà !

  • When does this issue occur? With any guestbook

  • Which page(s) does it occurs on? Guestbook (therefore dataset page and preview tab of files page)

  • What happens? Email are not checked

  • To whom does it occur (all users, curators, superusers)? File downloaders/explorers

  • What did you expect to happen? verify that the email address inputed is actually an email

Which version of Dataverse are you using? 5.14

Any related open or closed issues to this bug report? Functionally unrelated but on guestbook checks :

  • https://github.com/IQSS/dataverse/issues/9492

Screenshots:

https://github.com/IQSS/dataverse/assets/46443753/894368a5-f3fc-436b-849d-aac0978643ef

DS-INRAE avatar Jul 01 '24 12:07 DS-INRAE

related to #10625

qqmyers avatar Jul 01 '24 13:07 qqmyers

Related to the discussion on zulip on validators for guestbook, as that would impact the API part for these fields : https://dataverse.zulipchat.com/#narrow/stream/379673-dev/topic/metadata.20validators.20per.20field/near/449952746

DS-INRAE avatar Jul 09 '24 12:07 DS-INRAE

2024/08/19

  • This could also impact frontend (we would want validation in UI as well as backend)

cmbz avatar Aug 19 '24 16:08 cmbz