dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard
verified publisher icon IQSS

DataciteXML changes Plus RelationType field

Open qqmyers opened this issue 1 year ago • 3 comments

What this PR does / why we need it: This PR adds a RelationType child field to the related publication parent field and uses it to provide a RelationType in the OpenAire and DataCite XML exports, DataCite XML sent to dataset (and the JSON and OAI_ORE exports which include all fields). It builds upon #10615 and should be reviewed/QA'd after that (or we can create a PR against that branch to more easily see the changes just to add a RelationType.

Which issue(s) this PR closes:

Closes #

Special notes for your reviewer:

Suggestions on how to test this:

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

qqmyers avatar Jun 14 '24 22:06 qqmyers

Coverage Status

coverage: 20.869% (+0.2%) from 20.659% when pulling 6aade3a7df43647792a6627d41f871f85c69a676 on QualitativeDataRepository:datacite_plus_relPubRelType into 00020e2e14be599d49bbd7400d37454cf91717b7 on IQSS:develop.

coveralls avatar Jun 14 '24 22:06 coveralls

Coverage Status

coverage: 20.873% (+0.2%) from 20.659% when pulling c624c0c92fb555f82a33f69a12103967531a201d on QualitativeDataRepository:datacite_plus_relPubRelType into 00020e2e14be599d49bbd7400d37454cf91717b7 on IQSS:develop.

coveralls avatar Jun 19 '24 20:06 coveralls

Coverage Status

coverage: 20.848% (+0.2%) from 20.637% when pulling 394adcd6a2fbd0f80128f59e0e224eaea7dce6d5 on QualitativeDataRepository:datacite_plus_relPubRelType into 94b15e2556a1372fdfdfc788b26372a67b5130a7 on IQSS:develop.

coveralls avatar Jun 26 '24 17:06 coveralls

Coverage Status

Changes unknown when pulling 87bd3087aa16f77c5ea0f9c73db48d72d9b5e30b on QualitativeDataRepository:datacite_plus_relPubRelType into ** on IQSS:develop**.

coveralls avatar Jul 19 '24 19:07 coveralls

@qqmyers can you please resolve merge conflicts?

pdurbin avatar Sep 06 '24 15:09 pdurbin

OK - I think I addressed all the comments.

qqmyers avatar Sep 17 '24 18:09 qqmyers

Jenkins is failing but I pushed a minor doc tweak to force another run.

pdurbin avatar Sep 17 '24 18:09 pdurbin

I re-tested some more today, since the last changes were made this am. I am satisfied with the PR and ready to merge. But please stop me if you're thinking of making more changes.

landreev avatar Sep 23 '24 14:09 landreev

@scolapasta and @jggautier please review and update/close linked issues in PR body. Thanks!

cmbz avatar Sep 23 '24 18:09 cmbz

Hi @cmbz. I haven't been able to review and update/close linked issues in PR body since you asked last month because we've been planning for the UX WG to work on this.

So I think it's best if I help review and update/close linked issues in PR body as part of the UX WG's design sprint for improving descriptions of resources related to deposits, planned for after the current design sprint that's about improving descriptions of people and organizations related to deposits.

jggautier avatar Oct 18 '24 16:10 jggautier

Sounds good to me @jggautier. Pls ping me in Slack on these. They're easy to miss in the onslaught of GitHub notifications. Thanks!

cmbz avatar Oct 20 '24 16:10 cmbz