dataverse icon indicating copy to clipboard operation
dataverse copied to clipboard

8796 fix no license display and indexing

Open sekmiller opened this issue 1 year ago • 9 comments

What this PR does / why we need it: Modifies the display so that datasets which were updated in version 5.10 to have "Terms of Use" that actually indicate that no terms of use have been entered are not displayed with "Custom Terms" in the UI. Also, it updates the index service bean so that these datasets are not indexed as having Custom Terms

Which issue(s) this PR closes:

Closes #8796 Indicate on dataset page when dataset version has no license or custom Closes #10513 stop indexing datasets with no terms as "Custom Terms"

Special notes for your reviewer:

Suggestions on how to test this: I had to manually update the terms of use for some datasets to be :"This dataset is made available without information on how it can be used. You should communicate with the Contact(s) specified before use." Verify that these datasets are not indexed as having custom terms and not displayed as such in the UI.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?:

Additional documentation:

sekmiller avatar Jun 05 '24 19:06 sekmiller

I thought from https://github.com/IQSS/dataverse/issues/8796#issuecomment-2101276367 that this was going to be handled via non-active custom license for no terms and then removing the boilerplate text in termsofuse and adding that license at Harvard?

qqmyers avatar Jun 05 '24 19:06 qqmyers

Coverage Status

coverage: 20.57% (-0.003%) from 20.573% when pulling 7cb45960dfcad5b9e6f41c052769a174f2e8704a on 8796-fix-no-license-display-index into 3c55c3fa503b200fbe3b20e8d7d8965424e71160 on develop.

coveralls avatar Jun 05 '24 19:06 coveralls

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:8796-fix-no-license-display-index
ghcr.io/gdcc/configbaker:8796-fix-no-license-display-index

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Jun 05 '24 19:06 github-actions[bot]

Coverage Status

coverage: 20.57% (-0.003%) from 20.573% when pulling 3d9592cdc20ae20c339fdd59f975cdfcfe09081c on 8796-fix-no-license-display-index into 3c55c3fa503b200fbe3b20e8d7d8965424e71160 on develop.

coveralls avatar Jun 05 '24 20:06 coveralls

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:8796-fix-no-license-display-index
ghcr.io/gdcc/configbaker:8796-fix-no-license-display-index

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Jun 05 '24 20:06 github-actions[bot]

Coverage Status

coverage: 20.57% (-0.003%) from 20.573% when pulling 584dad757bbb5b9e438466b50e2b6fefdfac8a2e on 8796-fix-no-license-display-index into 3c55c3fa503b200fbe3b20e8d7d8965424e71160 on develop.

coveralls avatar Jun 05 '24 21:06 coveralls

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:8796-fix-no-license-display-index
ghcr.io/gdcc/configbaker:8796-fix-no-license-display-index

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Jun 05 '24 21:06 github-actions[bot]

Coverage Status

coverage: 20.571% (-0.003%) from 20.574% when pulling a9ec41650ba8704932f203363802227baeca7e76 on 8796-fix-no-license-display-index into 5bf6b6defb1c22971951233f30b679d762496832 on develop.

coveralls avatar Jun 10 '24 19:06 coveralls

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:8796-fix-no-license-display-index
ghcr.io/gdcc/configbaker:8796-fix-no-license-display-index

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Jun 10 '24 19:06 github-actions[bot]

Coverage Status

coverage: 20.639% (-0.004%) from 20.643% when pulling 194b099902132d50b4ae961fbd427f2b69f05541 on 8796-fix-no-license-display-index into 93e719741b37bd0b91066bcbbf7094b4f7ebd450 on develop.

coveralls avatar Jul 17 '24 15:07 coveralls

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:8796-fix-no-license-display-index
ghcr.io/gdcc/configbaker:8796-fix-no-license-display-index

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Jul 17 '24 15:07 github-actions[bot]

:package: Pushed preview images as

ghcr.io/gdcc/dataverse:8796-fix-no-license-display-index
ghcr.io/gdcc/configbaker:8796-fix-no-license-display-index

:ship: See on GHCR. Use by referencing with full name as printed above, mind the registry name.

github-actions[bot] avatar Jul 17 '24 16:07 github-actions[bot]